Closed
Bug 1245712
Opened 9 years ago
Closed 9 years ago
Fix the eslint XBL processor to output correct columns and handle whitespace more sensibly
Categories
(Toolkit :: General, defect)
Toolkit
General
Tracking
()
RESOLVED
FIXED
mozilla47
| Tracking | Status | |
|---|---|---|
| firefox47 | --- | fixed |
People
(Reporter: mossop, Assigned: mossop)
References
Details
Attachments
(1 file)
Because the code blocks that the processor hands off to eslint are re-indented to hopefully allow indent rules to pass the resulting errors have the wrong column number. Also the blocks include a lot of preceeding and trailing whitespace which are used for lining up XML tags. We have to remove these to allow the trailing whitespace rules to pass.
|
Assignee | |
Comment 1•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/33585/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33585/
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8715660 -
Flags: review?(mratcliffe)
Comment on attachment 8715660 [details]
MozReview Request: Bug 1245712: Fix the XBL processor's handling of columns and leading and trailing whitespace.
https://reviewboard.mozilla.org/r/33585/#review30223
Attachment #8715660 -
Flags: review?(mratcliffe) → review+
|
||
Comment 4•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•